Skip to content

Exposed SDKCall_Engine call type to use CVEngineServer methods#1648

Merged
peace-maker merged 3 commits intoalliedmodders:masterfrom
accelerator74:patch-1
Jul 26, 2022
Merged

Exposed SDKCall_Engine call type to use CVEngineServer methods#1648
peace-maker merged 3 commits intoalliedmodders:masterfrom
accelerator74:patch-1

Conversation

@accelerator74
Copy link
Contributor

@accelerator74 accelerator74 commented Nov 22, 2021

Similar to #1612 :)

I think this will be useful when used in plugins, where a pointer engine is needed. It will be convenient to use for vtable offsets to make it easier to call the necessary functions.

@accelerator74 accelerator74 changed the title Exposed SDKCall_Engine call type to use CIVEnginemethods Exposed SDKCall_Engine call type to use CIVEngineServer methods Nov 22, 2021
@accelerator74 accelerator74 changed the title Exposed SDKCall_Engine call type to use CIVEngineServer methods Exposed SDKCall_Engine call type to use CVEngineServer methods Nov 22, 2021
@accelerator74
Copy link
Contributor Author

My mistake :( Didn't know it was engine = iserver

@psychonic
Copy link
Member

My mistake :( Didn't know it was engine = iserver

?

They are not the same. This was valid.

@accelerator74
Copy link
Contributor Author

I checked some functions and they work with SDKCall_Server too. For example, GetPlayerNetInfo.

@accelerator74
Copy link
Contributor Author

Looked at this function again. It turns out that pointer is simply not very important to her, so in general the function is called as it should. Well, I'll reopen this PR if you think it should be :)

@accelerator74 accelerator74 reopened this Nov 22, 2021
@psychonic
Copy link
Member

Looked at this function again. It turns out that pointer is simply not very important to her, so in general the function is called as it should. Well, I'll reopen this PR if you think it should be :)

Yes, they are separate interfaces with separate interface pointers. The PR is valid.

Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less gamedata for plugins through providing readily available pointers is great.

@peace-maker peace-maker merged commit e5ebd65 into alliedmodders:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants