Fix translation buffers not terminating at last cell#1640
Merged
asherkin merged 1 commit intoalliedmodders:masterfrom Nov 16, 2021
Adrianilloo:1.10-dev
Merged
Fix translation buffers not terminating at last cell#1640asherkin merged 1 commit intoalliedmodders:masterfrom Adrianilloo:1.10-dev
asherkin merged 1 commit intoalliedmodders:masterfrom
Adrianilloo:1.10-dev
Conversation
Member
|
Please could you rebase and retarget this PR against the master branch. |
Contributor
Author
|
Ok, followed your steps now. Failed at trying to switch the source branch as well, but that isn't possible. |
Contributor
Author
|
Thanks! Will this be made into 1.10 as well? |
Member
We're not currently backporting non-critical things to 1.10 as we're in the final push for 1.11 - please do upgrade to 1.11 and test it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1594 per @dvander instructions and self tests