Exposed SDKCall_Server call type to use CBaseServer methods#1612
Merged
psychonic merged 1 commit intoalliedmodders:masterfrom Oct 26, 2021
dragokas:master
Merged
Exposed SDKCall_Server call type to use CBaseServer methods#1612psychonic merged 1 commit intoalliedmodders:masterfrom dragokas:master
psychonic merged 1 commit intoalliedmodders:masterfrom
dragokas:master
Conversation
psychonic
approved these changes
Oct 26, 2021
asherkin
reviewed
Oct 26, 2021
| SDKCall_Static, /**< Static call */ | ||
| SDKCall_Entity, /**< CBaseEntity call */ | ||
| SDKCall_Player, /**< CBasePlayer call */ | ||
| SDKCall_Server, /**< CBaseServer call */ |
Member
There was a problem hiding this comment.
@psychonic was this safe to add in the middle of the enum?
Contributor
|
Wouldn't putting a new enum value in the middle of the declaration ruin plugins compiled using Edit: Shucks, Asherkin beat me by 5 seconds. |
Member
|
Gahhhhh. You're both correct. |
Member
|
I've fixed it up now in 4b58b9f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully tested on L4D2 Linux with:
Thanks to Nuki for providing the code.