CritManager::Hook_CalcIsAttackCriticalHelpers() is a pre-hook that calls the appropriate helper function, then passes the result over to plugins to determine whether the value should be changed.

The issue is that MRES_IGNORED is used to return after calling the helper function if the result is Pl_Continue, causing the helper function to be called a second time after the function, resulting in the server's crit calculations desyncing from the clients'. This PR stores the original return value and supercedes so it only ever gets called once.

Tested on a fresh server with the below plugin to listen for crits (and to force the hook to be enabled). Without the fix, a Soldier's rocket may have glow without the sound or vice-versa; with the fix applied, the rocket will have both or neither.

#pragma semicolon 1
#include <sourcemod>

#include <tf2>

#pragma newdecls required

public Action TF2_CalcIsAttackCritical(int client, int weapon, char[] weaponname, bool& result) {
	PrintToChat(client, "%s crit: %b", weaponname, result);
	return Plugin_Continue;
}

thx @FlaminSarge for giving me something to do