Conversation
asherkin
force-pushed
the
legacy-gamerules
branch
2 times, most recently
from
fa11c54 to
ce751d6
Compare
This rounds out the work started in #1548 to complete support for reading the older SendPropArray type array netprops, along with bringing SDKTools' GameRule netprop code in sync with core to add string array support. There aren't many SendPropArray type props around but this opens up a few interesting opportunities for plugin developers, particularly in L4D2 with manipulation of the EMS HUD. Tested reading the `m_vCPPositions` array in TF2, and reading/writing the `m_szScriptedHUDStringSet` EMS HUD netprop in L4D2. Closes #1386.
asherkin
force-pushed
the
legacy-gamerules
branch
from
ce751d6 to
7dda0f3
Compare
6 tasks
dvander
approved these changes
Aug 23, 2021
| { | ||
| return pContext->ThrowNativeError("Setting string_t gamerules prop %s not supported yet.", prop); | ||
|
|
||
| // *(string_t *)((intptr_t)pGameRules + offset) = g_HL2.AllocPooledString(src); |
Member
Author
There was a problem hiding this comment.
Yeah, the extension API needs some work to expose AllocPooledString from core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rounds out the work started in #1548 to complete support for
reading the older SendPropArray type array netprops, along with bringing
SDKTools' GameRule netprop code in sync with core to add string array
support.
There aren't many SendPropArray type props around but this opens up a
few interesting opportunities for plugin developers, particularly in
L4D2 with manipulation of the EMS HUD.
Tested reading the
m_vCPPositionsarray in TF2, and reading/writingthe
m_szScriptedHUDStringSetEMS HUD netprop in L4D2. Closes #1386.