Conversation
In #545 we started automatically fixing up invalid UTF8 characters caused by truncated names from Steam, but since the dawn of time CPlayer has preferred directly returning the engine's name pointer if we have once available, so our corrected name is almost never used. Lightly tested in CS:GO and TF2 with no ill effects. Fixes #1315
Member
|
Can we return the engine value if our cache is invalid (and then store the result in our cache?). |
Member
Author
|
I don't think there can ever be a point that the name isn't set - the previous code here was explicitly using it early when the engine player info wasn't available. |
KyleSanderson
approved these changes
Aug 1, 2021
NotPowered
reviewed
Sep 12, 2021
NotPowered
left a comment
NotPowered
left a comment
There was a problem hiding this comment.
This modification has integrated a regression
Names set with SetInfo are now not returned properly.
So we have a display name = B (in scoreboard, chat etc ... with SetInfo and when we do GetClientName we have a name A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #545 we started automatically fixing up invalid UTF8 characters
caused by truncated names from Steam, but since the dawn of time CPlayer
has preferred directly returning the engine's name pointer if we have
once available, so our corrected name is almost never used.
Lightly tested in CS:GO and TF2 with no ill effects. Fixes #1315