Conversation
Similar to the recent work for commands, track and expose the creating plugin for convars. The first plugin to register a given cvar becomes the owner until that plugin is unloaded. If a plugin attempts to register a convar that was already registered and the originally registering plugin has been unloaded, that plugin becomes the owner. This isn't quite as nice as the way commands shift "ownership" as plugins are unloaded, but we don't have a sane data structure currently to implement that, and it seemed like a lot of unnecessary work as there shouldn't really be multiple plugins with conflicting cvars. Closes #1492
Member
Author
|
Tested with: public void OnPluginStart()
{
PrintConVar("sm_chat_mode");
PrintConVar("sv_alltalk");
}
void PrintConVar(const char[] name)
{
ConVar cvar = FindConVar(name);
Handle plugin = cvar.Plugin;
char filename[PLATFORM_MAX_PATH];
if (plugin)
GetPluginFilename(plugin, filename, sizeof(filename));
PrintToServer(">>> %s: %x %x - \"%s\"", name, cvar, plugin, filename);
}Unloaded, loaded, reloaded basechat (provider of |
Headline
approved these changes
Jul 18, 2021
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
All this looks good - thanks!
| } | ||
|
|
||
| /* Clear any references to this plugin as the convar creator */ | ||
| for (List<ConVarInfo *>::iterator iter = m_ConVars.begin(); iter != m_ConVars.end(); ++iter) |
Member
There was a problem hiding this comment.
We should probably get used to using ranged-for, but it's just a nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the recent work for commands, track and expose the creating
plugin for convars. The first plugin to register a given cvar becomes
the owner until that plugin is unloaded. If a plugin attempts to
register a convar that was already registered and the originally
registering plugin has been unloaded, that plugin becomes the owner.
This isn't quite as nice as the way commands shift "ownership" as
plugins are unloaded, but we don't have a sane data structure currently
to implement that, and it seemed like a lot of unnecessary work as there
shouldn't really be multiple plugins with conflicting cvars.
Closes #1492