Add parameter to configure updating page permissions in StoreToAddress#1523
Merged
KyleSanderson merged 2 commits intoalliedmodders:masterfrom Jul 10, 2021
Merged
Conversation
Contributor
|
If speed is so important to you, then I suggest that you the write of a cell in memory without access changes in a separate native. Also, I had the idea to make a additional |
KyleSanderson
approved these changes
Jul 10, 2021
Member
|
The use-case is pretty terrible and is prone to corrupting state without extreme safety taken. However, writing memory should not be crazy more expensive than EntData which is ever so slightly more safe, so I've taken this in. Please do not use this, or EntData, and use EntProp whenever possible when manipulating networked entity data. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1375.
This adds a new optional parameter to
StoreToAddress, allowing plugins to opt out of having SourceMod update page permissions every time it writes to memory.Tested in TF2 with the following micro benchmark:
Micro benchmark source code:
Micro benchmark results: