Skip to content

Increase buffer size for map name & DisplayName#1512

Merged
asherkin merged 1 commit intoalliedmodders:masterfrom
xerox8521:patch-1
Jul 17, 2021
Merged

Increase buffer size for map name & DisplayName#1512
asherkin merged 1 commit intoalliedmodders:masterfrom
xerox8521:patch-1

Conversation

@xerox8521
Copy link
Contributor

This increases the buffer to store the map name to be consistent with the other calls to GetCurrentMap. Also currentmap now uses the map's display name similar how nextmap uses it.

This increases the buffer for the map to be consistent with the other calls to GetCurrentMap. Also `currentmap` now uses the map's display name similar how `nextmap` uses it.
Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asherkin asherkin merged commit 4d6b989 into alliedmodders:master Jul 17, 2021
@dragokas
Copy link
Contributor

What now?
After this commit I'll receive an empty output instead of map name for some maps.

@asherkin
Copy link
Member

After this commit I'll receive an empty output instead of map name for some maps.

This PR is just aligning one chat trigger with the behaviour of everything else displaying maps, if you're having an issue generally you should open an issue with some details, especially an example of a map with that problem. GetMapDisplayName explicitly uses the input string on failure.

@dragokas
Copy link
Contributor

Ok, thanks.
And strange, the issue is no more reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants