Add StringToInt64() and Int64ToString() natives#1511
Merged
asherkin merged 4 commits intoalliedmodders:masterfrom Jun 28, 2021
Merged
Add StringToInt64() and Int64ToString() natives#1511asherkin merged 4 commits intoalliedmodders:masterfrom
asherkin merged 4 commits intoalliedmodders:masterfrom
Conversation
Contributor
Author
Member
|
Nice! This is a good interim solution and something I've been intending to add a format specifier for doing for ages. Could you add some test cases to the test suite? (Or share a test plugin and test results here.) |
Member
|
|
dvander
requested changes
Jun 25, 2021
dvander
approved these changes
Jun 28, 2021
Member
|
I wonder if |
Member
|
I'm ambivalent. Using int64 ids as anything other than strings is a bad idea unless there's some mathematical calculation going on. As numbers they are not portable to other languages (eg JavaScript/JSON). |
asherkin
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.