Removing the IsInGame() check should be fine since EmitSound eventually uses CGameClient::IsActive() to only send to active clients.

Did you check if this is true for all engine versions SM supports? Did you actually test it on any?

Removing the IsInGame() check should be fine since EmitSound eventually uses CGameClient::IsActive() to only send to active clients.

Did you check if this is true for all engine versions SM supports? Did you actually test it on any?

It looks like it has always checked if the client is active in both older and newer engine versions.
Also it was a CSGO server that was throwing these sourcemod errors about players not being ingame after returning Plugin_Changed in NormalSHook.

I really don't remember why this was added, I think I hit a filter or something that crashed on a mid-connecting client. That's the reason this one hasn't been merged yet, I know it's painful but the only path to merge this one would be to test every game presently.

Alternatively, how about removing the client from the players array if not IsInGame()?

Alternatively, how about removing the client from the players array if not IsInGame()?

I think that's a fine idea

I force pushed a commit to remove clients from the players array if not IsInGame and also to check if the size variable is valid.

edit:
also instead of

memmove(&players[i], &players[i+1], (size-i-1) * sizeof(int));
--i;
--size;

this would be funny

memmove(&players[i], &players[i+1], (size-- - --i) * sizeof(int));