Add ConVar.GetDescription() method#1449
Conversation
Add prints description of ConVar
|
Works |
plugins/include/convars.inc
Outdated
| * @param maxlength Maximum length of string buffer. | ||
| * @error Invalid or corrupt Handle. | ||
| */ | ||
| native void GetConVarDescription(Handle convar, char[] buffer, int maxlength); |
There was a problem hiding this comment.
I understand adding this for the sake of completion, but we don't add old style functions for new features. Rest looks good to me, though! 😄
|
We need to figure out how to handle changes to translation phrases before merging this! |
I followed the standards set by sourcemod/plugins/basecommands.sp Lines 65 to 66 in ad48506 Phrases from ConVars are found in these 2 files. I think this already needs to be speak with a solution, outside of this pull request. |
|
Yes, sorry, this is nothing wrong with your changes. Just like #597 changes to the translation files have to be reflected in the translator tool used to gather all the different languages. That update isn't automated yet and the process of translation hasn't been revisited since SourceMod switched to a rolling release cycle afaik. |
|
I think it would be best to remove the basecommands changes so we can get the new API merged. |
This reverts commit ad48506.
peace-maker
left a comment
peace-maker
left a comment
There was a problem hiding this comment.
The non-methodmap native needs to go, but otherwise this looks great!
|
When there was an active change with |
|
|
4 participants
Issue #1432