Update IPlugin reference on cmd hook removal#1439
Merged
Conversation
Headline
force-pushed
the
fix-cmditer-crash
branch
from
05d7bc1 to
75d43a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1387
When two separate plugins hook the same cmd and one of those plugins are unloaded (or reloaded), then the IPlugin reference is never updated on the
CmdInfoobject, therefore when we try to get the plugin handle afterwards we explode. This patch identifies plugins on the hook level as well, that way when the owning plugin is unloaded we can update the IPlugin reference to the next hook in line.