fix issues when loading randomcycle from disabled folder#1428
fix issues when loading randomcycle from disabled folder#1428Headline merged 3 commits intoalliedmodders:masterfrom sapphonie:master
Conversation
|
So |
If the map changes twice from our data model there can be multiples of these timers running because this isn't killed with fire when the level ends. To fix this one I think we just need TIMER_FLAG_NOMAPCHANGE and nuke the global as it isn't needed and welcomes glitches. There was an ancient issue with OnConfigsExecuted firing multiple times, and that could indeed be the issue here (if you want to step through with a debugger that would be cool). However, I'd suspect there's multiple map plugins loaded at the moment, so the server is changing levels twice (which also happened to me, over 10 years ago). I do believe the current PR resolves the issue, but I don't believe it's the correct fix. |
peace-maker
left a comment
peace-maker
left a comment
There was a problem hiding this comment.
Thank you for bringing this up! Please consider the following change if you have the time!
KyleSanderson
left a comment
KyleSanderson
left a comment
There was a problem hiding this comment.
The flag is in the wrong arg.
4 participants
currently, when loading randomcycle, it runs
Timer_RandomizeNextmaptwice, leading to odd behavior where the map gets changed twice after timelimit is reached. This fixes that issue by only allowing the timer to be run once per map.