Add sm_dump_datamaps_xml#1409
Merged
Headline merged 2 commits intoalliedmodders:masterfrom Mar 8, 2021
Scags:datamaps-xml
Merged
Add sm_dump_datamaps_xml#1409Headline merged 2 commits intoalliedmodders:masterfrom Scags:datamaps-xml
Headline merged 2 commits intoalliedmodders:masterfrom
Scags:datamaps-xml
Conversation
Headline
requested changes
Mar 7, 2021
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
Looks good!
Just that one tiny bit I believe
Headline
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an
sm_dump_netprops_xmlbut not ansm_dump_datamaps_xmland since I went a bit nuts parsing a plain text file, I thought it would be useful to extend it into a parsable format.This also adds the element offset for sub-class tables since I needed them for my exact purpose.