It must be noticed that SDKHook_Think doesn't seem to be the only case.

• SDKHook_PreThink
• SDKHook_PostThink
• SDKHook_VPhysicsUpdate

have the same issue.

It should be let to the user the possibility to block any game call in pre-hooks (At his own risk...), or else put in the documentation that for these cases the return value is discarded (For security purposes...).

@psychonic

this seems fine to me outside of the crunched style. WDYT?

EDIT: Github styling was not expected.

@asherkin do you know the implications of what happens when an entity stops thinking by chance?

@asherkin do you know the implications of what happens when an entity stops thinking by chance?

I do not, but it'll be entity-specific and should generally be fine.

or else put in the documentation that for these cases the return value is discarded.

It is in the documentation,

typeset SDKHookCB
{
	// PreThink/Post
	// PostThink/Post
	function void (int client);

	// Spawn
	function Action (int entity);

	// GroundEntChanged
	// SpawnPost
	// Think/Post
	// VPhysicsUpdate/Post
	function void (int entity);

That'll need updating for this change as well.

@asherkin Indeed, I missed the callback prototype. Thinking about it now, but will it not break the compatibility with some plugins (And are we okay with this)...?

By the way, what's your opinion about doing the same thing for the three following hooks:

• SDKHook_PreThink
• SDKHook_PostThink
• SDKHook_VPhysicsUpdate

I updated sdkhooks.inc. Let's see for other hooks later.