Update cookie funcs to return Cookie methodmap#1379
Merged
Headline merged 5 commits intoalliedmodders:masterfrom Nov 7, 2020
JoinedSenses:patch-1
Merged
Update cookie funcs to return Cookie methodmap#1379Headline merged 5 commits intoalliedmodders:masterfrom JoinedSenses:patch-1
Headline merged 5 commits intoalliedmodders:masterfrom
JoinedSenses:patch-1
Conversation
Just like the behavior of functions like CreateArray which return ArrayList, cookie functions should return Cookie.
peace-maker
requested changes
Nov 5, 2020
Member
peace-maker
left a comment
peace-maker
left a comment
There was a problem hiding this comment.
Since the keyword is lowercase, documenting it as Null might confuse users when they copy it from the docs? INVALID_HANDLE had unambiguous casing before 😄
Co-authored-by: peace-maker <[email protected]>
Co-authored-by: peace-maker <[email protected]>
Contributor
Author
¯\_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like the behavior of functions like CreateArray which return ArrayList, cookie functions should return Cookie.