Conversation
asherkin
added a commit
that referenced
this pull request
Jul 17, 2021
When a netprop is an array the name resolves to the outer DataTable array, which we then need to recurse into to find the actual prop. For string_t props we need their sendprop info to call the proxy function to get their real storage address, but when accessing an array we were trying to read the prop off the outer DataTable prop, rather than the real string_t prop. Fix this by using the pProp variable that FIND_PROP_SEND helpfully provides for us. Tested by writing/reading the `m_szCrosshairCodes` array, which got changed to a string_t prop sometime since #1372. Fixes #1484
asherkin
added a commit
that referenced
this pull request
Jul 18, 2021
When a netprop is an array the name resolves to the outer DataTable array, which we then need to recurse into to find the actual prop. For string_t props we need their sendprop info to call the proxy function to get their real storage address, but when accessing an array we were trying to read the prop off the outer DataTable prop, rather than the real string_t prop. Fix this by using the pProp variable that FIND_PROP_SEND helpfully provides for us. Tested by writing/reading the `m_szCrosshairCodes` array, which got changed to a string_t prop sometime since #1372. Fixes #1484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stumbled across this on the forum, https://forums.alliedmods.net/showthread.php?t=327642.
Reading SendProp strings (char *, not string_t) broke at some point, due to us not deref-ing enough. Support for string prop arrays was also missing because of not using our macros that handle that. Both fixed. Tested on CS:GO getting/setting m_szCrosshairCodes on the player resource entity, and m_szLastPlaceName on a player entity.