Merged
Conversation
KyleSanderson
approved these changes
Oct 2, 2020
Member
|
Indeed. CPUs over the past decade + have come a long way with caching. This was a great feature at the time, but garbage collecting like this now per type is not really necessary (and may actually increase fragmentation / misses). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Killing CDataPack's cache has been something on my list for a while - I'm not exactly sure when this became so easy (probably once IDataPack died), but here we are.
Technically, before this patch, we'd hold on to datapacks forever and their memory was never freed, we'd just save them for reuse. I do not think we're concerned anymore with the cost of allocating and deallocating this memory as-needed, so I'm just removing some bloat here.