Updated 'checkout-deps' to check for 'pip'/'pip3' prior to installing 'AMBuild'#1328
Merged
dvander merged 1 commit intoalliedmodders:masterfrom Jul 31, 2020
WildCard65:checkout-deps_fixes
Merged
Updated 'checkout-deps' to check for 'pip'/'pip3' prior to installing 'AMBuild'#1328dvander merged 1 commit intoalliedmodders:masterfrom WildCard65:checkout-deps_fixes
dvander merged 1 commit intoalliedmodders:masterfrom
WildCard65:checkout-deps_fixes
Conversation
Contributor
Author
|
@dvander Care to review this please? |
Member
|
It strikes me that we should probably throw these scripts into a common repository, updating them in ~5 places is painful. Oh well, another day. Thanks for doing this. |
Member
|
I've noticed, with this change |
Contributor
Author
|
That's more of an issue with the version number of AMBuild.
…On Wed., Aug. 19, 2020, 9:25 a.m. peace-maker, ***@***.***> wrote:
I've noticed, with this change checkout-deps doesn't update ambuild
anymore if it is already installed. I liked that behavior beforehand, being
able to run one script to get the build environment up-to-date.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGFQE4AAVWLNI5UXLR5VFLSBPHGBANCNFSM4PQ67HWA>
.
|
Member
|
I thought |
Contributor
Author
|
Oh, the PowerShell script didn't check for AMbuild beforehand while the shell script did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkout-deps (PowerShell/BASH):
checkout-deps.ps1
Closes #1324
See: alliedmodders/ambuild#68