Fix velocities assignment of SDKHooks_TakeDamage#1322
Merged
KyleSanderson merged 6 commits intoalliedmodders:masterfrom Aug 7, 2020
PerfectLaugh:master
Merged
Fix velocities assignment of SDKHooks_TakeDamage#1322KyleSanderson merged 6 commits intoalliedmodders:masterfrom PerfectLaugh:master
KyleSanderson merged 6 commits intoalliedmodders:masterfrom
PerfectLaugh:master
Conversation
Member
|
@psychonic what do you think about this one? I didn't go back to mercurial to look at how it happened but it looks like an innocent enough issue. My only concern is knockback plugins rely on these values, fixing them will obviously change behaviour. @ErikMinekus any thoughts on this one? |
psychonic
approved these changes
Aug 7, 2020
psychonic
pushed a commit
that referenced
this pull request
Mar 20, 2022
* Attempt to correct SDKHooks_TakeDamage * Define function on both csgo and non-csgo * Remove unneeded macros * Fix velocity copy on CTakeDamageInfoHack init (cherry picked from commit 031f80f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug make SDKHooks_TakeDamage's velocity arguments cannot be passed to constructed CTakeDamageInfoHack, causing no damage velocity generated.