Conversation
Headline
added
Bug
asherkin
approved these changes
Jul 11, 2020
Member
|
The build config and instructions as well as the library version currently checked in should be documented somewhere in the tree. |
KyleSanderson
previously requested changes
Jul 11, 2020
Member
KyleSanderson
left a comment
KyleSanderson
left a comment
There was a problem hiding this comment.
NAK (for now). P-M is right, reach out to me please.
asherkin
dismissed
KyleSanderson’s stale review
Stale - other bit better addressed separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1294 and is related to #1295
This adds a version of the pcre library for windows x64 builds. For future recompilation of pcre, I'll go into some detail about the process of windows compilation for historical purposes should I or someone else have to do this again.
As of writing, we're using pcre v8.32
We build with the MinSizeForRelease VS configuration using the target architecture you want. This is how both win libs are built. The following settings were selected in the CMAKE configuration
In the PCRE project, go to C/C++ configuration properties and select the Runtime Library to be Multi-threaded (
/MT) instead of Multi-threaded DLL (/MD)