Provide ArrayStack.Clone method#1304
Merged
KyleSanderson merged 2 commits intoalliedmodders:masterfrom Jul 9, 2020
Merged
Conversation
dvander
reviewed
Jul 7, 2020
plugins/include/adt_stack.inc
Outdated
| * @return New handle to the cloned stack object | ||
| * @error Invalid Handle | ||
| */ | ||
| native ArrayStack CloneStack(Handle stack); |
Member
There was a problem hiding this comment.
No reason to provide old-style natives anymore.
Contributor
Author
There was a problem hiding this comment.
Then i remove it?
Member
There was a problem hiding this comment.
Yeah, indeed. This encourages using the newer APIs.
KyleSanderson
approved these changes
Jul 9, 2020
Member
|
thanks for the contribution @TheByKotik |
rumblefrog
reviewed
Jul 9, 2020
| REGISTER_NATIVES(cellStackNatives) | ||
| { | ||
| {"CreateStack", CreateStack}, | ||
| {"CloneStack", CloneStack}, |
Contributor
There was a problem hiding this comment.
Would this need cleanup as well? Or are just ridding the definition.
Member
There was a problem hiding this comment.
eh, it's an internal thing. We're all adults, if someone really wants to get at this they can.
Contributor
Author
There was a problem hiding this comment.
Maybe then create RP with total old-style cleanup?
Or it's excess?
Member
|
This is a duplicate of #852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide ArrayStack.Clone method.
Tested with this script.