Conversation
Headline
reviewed
May 31, 2020
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
I didn’t ditto repeated changes
I’m cool with taking this as-is if we want to finalize it later, but we can clean up more
| return false; | ||
|
|
||
| m_items.remove(position); | ||
| ke::RemoveAt(&m_items, position); |
Member
There was a problem hiding this comment.
Any reason we’re not doing
m_items.erase(m_items.begin()+ position)
| val.pData.vval = new uint8_t[size + sizeof(size)]; | ||
| reinterpret_cast<size_t *>(val.pData.vval)[0] = size; | ||
| elements.insert(position, val); | ||
| ke::InsertAt(&elements, position, val); |
| } | ||
| void ReleaseMembers() { | ||
| for (size_t i = 0; i < this->length(); i++) { | ||
| for (size_t i = 0; i < this->size(); i++) { |
Member
Author
There was a problem hiding this comment.
To minimize friction (and time spent writing these patches), I tried to make these changes as syntax-preserving as I could. Improvements like range-based for loops can be done as needed. The argument for RemoveAt/InsertAt is weaker though so I'll revert those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.