Fix unnecessary ConCommand cache misses#1256
Conversation
Fixes a rare crash caused by GetCommandFlags() if there are some commands registered by plugins (Reg*Cmd()) which containing capitals. The same command ending up in the cache multiple times would explain the bug. (https://crash.limetech.org/stats/dc3d4e0530c48bb491d6b448c5a4d8a3)
|
This is the same problem as it was in #1166, but related to ConCommand rather than ConVar. |
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
This looks correct to me for fixing the issue - I wanted to have a look to see if we could do a more efficient implementation but it probably makes sense to take this as-is to fix the bug.
Fix unnecessary ConCommand cache misses (alliedmodders#1256)
|
Any plans with this changes move to stable build? |
|
It won't be backported to 1.10, but 1.11 is very usable and we're hard at work towards getting it promoted. |
|
Those array enum structs sadly won't magically recode themselves to the new enum structs. |
|
You can always compile the plugins using deprecated syntax with an older compiler until they're updated. The .smx created by any older compiler will load and run fine on newer runtimes. The forum remembers which compiler version was used to create the plugin in the release post and uses the correct version when clicking "Get Plugin". I know this isn't optimal, but at least you don't HAVE to touch a plugin's code just to use it. |
5 participants
Fixes a rare crash caused by GetCommandFlags() if there are some commands registered by plugins (Reg*Cmd()) which containing capitals. The same command ending up in the cache multiple times would explain the bug. (https://crash.limetech.org/stats/dc3d4e0530c48bb491d6b448c5a4d8a3)