Fix matching Regex against an empty string#1253
Merged
psychonic merged 1 commit intoalliedmodders:masterfrom Apr 29, 2020
Merged
Fix matching Regex against an empty string#1253psychonic merged 1 commit intoalliedmodders:masterfrom
psychonic merged 1 commit intoalliedmodders:masterfrom
Conversation
Removed the offset check from MatchRegex, as this is already handled by pcre_exec.
dvander
approved these changes
Apr 28, 2020
fengjixuchui
added a commit
to fengjixuchui/sourcemod
that referenced
this pull request
Apr 29, 2020
Fix matching Regex against an empty string (alliedmodders#1253)
asherkin
pushed a commit
that referenced
this pull request
Apr 30, 2020
Removed the offset check from MatchRegex, as this is already handled by pcre_exec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching a Regex against an empty string throws an exception:
Which is caused by this check:
Because
offsetandlenare both 0.However, this check is redundant, because
pcre_exec()already returnsPCRE_ERROR_BADOFFSETif the offset is negative or greater than the passed length, and RegexError already supports this.