Always use hl2sdk-proxy-repo in checkout-deps#1236
Merged
Headline merged 3 commits intoalliedmodders:masterfrom May 8, 2020
Merged
Always use hl2sdk-proxy-repo in checkout-deps#1236Headline merged 3 commits intoalliedmodders:masterfrom
Headline merged 3 commits intoalliedmodders:masterfrom
Conversation
There were two separate issues with the checkout-deps scripts on windows and linux. Windows didn't use the hl2sdk repository mirror "hl2sdk-proxy-repo" when cloning the different engine branches into their own folders like `hl2sdk-csgo`, `hl2sdk-css`, ... but cloned from github.com every time. When rerunning the checkout-deps.ps1 script later it would fail to find the "hl2sdk-proxy-repo" folder and fail to update the sdks. Linux did use the local mirror repository for the initial clone of the different game sdk branches, but used github.com for later updates of the game sdks instead of using the local mirror. Fix both scripts to always use the local mirror.
Member
Author
|
Hm, thinking a little further. Maybe a better way would be to only temporarily switch to the local proxy repo when updating the sdks through the |
Member
|
That seems reasonable. |
Keep the hl2sdk git origin at the remote github.com repository, but shortly switch to the local mirror when using the checkout-deps scripts. This allows to pull changes for a single hl2sdk by hand without the need to fetch changes in the proxy-repo first.
Headline
approved these changes
May 8, 2020
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
This sped up cloning significantly in some simple tests; thanks PM ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two separate issues with the checkout-deps scripts on windows and linux.
Windows didn't use the hl2sdk repository mirror "hl2sdk-proxy-repo" when cloning the different engine branches into their own folders like
hl2sdk-csgo,hl2sdk-css, ... but cloned from github.com every time. When rerunning the checkout-deps.ps1 script later it would fail to find the "hl2sdk-proxy-repo" folder and fail to update the sdks.Linux did use the local mirror repository for the initial clone of the different game sdk branches, but used github.com for later updates of the game sdks instead of using the local mirror.
Fix both scripts to always use the local mirror.
Looks like the AppVeyor config has to be updated too if it doesn't use the checkout-deps.ps1 script. #969