Skip to content

Prevent clients from spamming global chat using sm_nominate#1217

Merged
asherkin merged 2 commits intoalliedmodders:masterfrom
Douile:patch-1
Mar 21, 2020
Merged

Prevent clients from spamming global chat using sm_nominate#1217
asherkin merged 2 commits intoalliedmodders:masterfrom
Douile:patch-1

Conversation

@Douile
Copy link
Contributor

@Douile Douile commented Mar 21, 2020

Using the nominate command it is possible to spam global chat by alternating between two maps e.g.
bind mwheeldown "sm_nominate de_dust2;sm_nominate de_mirage;"
By replying to successful nominations instead of putting in global this issue is prevented as clients can only spam themselves.

Using the nominate command it is possible to spam global chat by alternating between two maps e.g.
`bind mwheeldown "sm_nominate de_dust2;sm_nominate de_mirage;"`
By replying to successful nominations instead of putting in global this issue is prevented as clients can only spam themselves.
@asherkin
Copy link
Member

How do you feel about broadcasting it if the result is not Nominate_Replaced? I think it is quite important to advertise the nominations as it lets people know they can nominate maps, but yeah it doesn't make sense to let people constantly do it like this.

@Douile
Copy link
Contributor Author

Douile commented Mar 21, 2020

@asherkin I do think it would be useful to see nominations globally. The only other way I see to fix is by adding some kind of rate limiting to the command.
EDIT: Anti-flood will kick clients that completely spam the command but a client can still prevent chat from being used by slowly spamming the commands.

Copy link
Contributor Author

@Douile Douile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that seems like a better idea than never printing globally

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@asherkin asherkin merged commit 7f239bb into alliedmodders:master Mar 21, 2020
@Naleksuh
Copy link

@asherkin You can do something similar with votes and sm_revote - should this be changed similarly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants