Clarify detour creation errors#1191
Closed
sm9cc wants to merge 1 commit intoalliedmodders:masterfrom
sm9cc:clarify-detour-creation-errors
Closed
Clarify detour creation errors#1191sm9cc wants to merge 1 commit intoalliedmodders:masterfrom sm9cc:clarify-detour-creation-errors
sm9cc wants to merge 1 commit intoalliedmodders:masterfrom
sm9cc:clarify-detour-creation-errors
Conversation
asherkin
approved these changes
Feb 26, 2020
asherkin
pushed a commit
that referenced
this pull request
Feb 26, 2020
A logic error here meant that it wasn't printing the failing sig name in the common case
Member
|
Merged this manually, not sure why GH hasn't picked that up. |
asherkin
pushed a commit
that referenced
this pull request
Feb 26, 2020
A logic error here meant that it wasn't printing the failing sig name in the common case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, thanks Asherkin & FortyTwoFortyTwo