Fix wording of IsServerProcessing comment.#1188
Merged
KyleSanderson merged 1 commit intoalliedmodders:masterfrom Feb 26, 2020
JoinedSenses:patch-3
Merged
Fix wording of IsServerProcessing comment.#1188KyleSanderson merged 1 commit intoalliedmodders:masterfrom JoinedSenses:patch-3
KyleSanderson merged 1 commit intoalliedmodders:masterfrom
JoinedSenses:patch-3
Conversation
Wording of comment was a bit off.
Contributor
Author
|
On top of fixing readability, I added in context for hibernation; however, some folks in the SM discord suggest that timers will continue to work now in hibernation. Can anyone verify? |
KyleSanderson
approved these changes
Feb 26, 2020
Member
KyleSanderson
left a comment
KyleSanderson
left a comment
There was a problem hiding this comment.
This is better wording - but not an API guarantee. I'm merging this regardless as it's closer to what we presently have but it's problematic still because it's talking about internal semantics.
rumblefrog
added a commit
to rumblefrog/sp-gid
that referenced
this pull request
Feb 27, 2020
TeleportEntity def value: alliedmodders/sourcemod#1167 MatchRegex added offset param: alliedmodders/sourcemod#1175 IsServerProcessing documentation wording: alliedmodders/sourcemod#1188 TR_EnumerateEntities(Sphere/Box/Point): alliedmodders/sourcemod#1145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment wording is incoherent.