Add stock AssertStrEq to testing include#1185
Merged
KyleSanderson merged 2 commits intoalliedmodders:masterfrom Jul 9, 2020
Merged
Add stock AssertStrEq to testing include#1185KyleSanderson merged 2 commits intoalliedmodders:masterfrom
KyleSanderson merged 2 commits intoalliedmodders:masterfrom
Conversation
KyleSanderson
requested changes
Feb 26, 2020
Member
KyleSanderson
left a comment
KyleSanderson
left a comment
There was a problem hiding this comment.
This is meant for testing - not production. For completeness/lineage can you please mention how this came to be and why it's important for your project.
Contributor
Author
|
Sure; this came out of a desire to ensure strings were correct in the test suite for the TF2 Econ Data compatibility shim, which checks to see that both the compatibility shim and the original TF2ItemsInfo natives function similarly. I'd also like to make use of it in tests for the double extension if this gets accepted. |
Headline
approved these changes
May 8, 2020
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
I think this is harmless and can be pulled in for others to use, that way there's no Frankenstein-ing of testing stuffs.
@KyleSanderson thoughts?
KyleSanderson
approved these changes
Jul 9, 2020
Member
fengjixuchui
added a commit
to fengjixuchui/sourcemod
that referenced
this pull request
Jul 9, 2020
testing: Add stock AssertStrEq (alliedmodders#1185)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new stock function
AssertStrEqto assert equality between two strings.It's a minor convenience over
AssertTruesince it prints the expected string without having to include it in thetextargument.