Regex Little Changes#1175
Merged
KyleSanderson merged 4 commits intoalliedmodders:masterfrom Feb 26, 2020
Merged
Conversation
* Prevented to triple and double call `strlen`. * More informative message on `if (offset >= len)`. * Add missing parametr in navite `MatchRegex`.
Headline
requested changes
Feb 9, 2020
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
Thanks for the cleanup and missing param discovery!
Just a few comments and this one should be good to go
* Using `strdup` instead `strcpy`. * Replaced NULL to nullptr. * Removed note about MatchOffset. Co-Authored-By: Headline <[email protected]>
Headline
requested changes
Feb 10, 2020
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
two more nits and this is good
Co-Authored-By: Headline <[email protected]>
Headline
requested changes
Feb 10, 2020
Co-Authored-By: Headline <[email protected]>
Member
|
Has this been tested? |
Contributor
Author
Windows build only with test.sp. |
Headline
approved these changes
Feb 11, 2020
Member
|
Not really a bug but a feature request. Nice hidden API exposure there buddy :-) thanks for the PR and resolving this. |
rumblefrog
added a commit
to rumblefrog/sp-gid
that referenced
this pull request
Feb 27, 2020
TeleportEntity def value: alliedmodders/sourcemod#1167 MatchRegex added offset param: alliedmodders/sourcemod#1175 IsServerProcessing documentation wording: alliedmodders/sourcemod#1188 TR_EnumerateEntities(Sphere/Box/Point): alliedmodders/sourcemod#1145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strlen.if (offset >= len).MatchRegex.P.S. I'm have little exp in c++, sorry if something wrong.