Fix documentation on DataPack methods#1164
Fix documentation on DataPack methods#1164Headline merged 3 commits intoalliedmodders:masterfrom Deathreus:vector-dp
Conversation
There was a problem hiding this comment.
Good catch on the documentation changes!
Since DataPacks have strict type checking, reading a float where an int would be read will throw an error. To keep this consistent float[3] "vectors" should probably be given their own type internally instead of papering over this with a loop of WriteFloats.
It's a nice ease-of-use addition, but if we take this I think it'd have to be via it's own read/write natives.
Thanks for contributing!
|
Would it be better to have |
Actually, yeah, that would be far better, I'll commit that instead at the native level |
Deathreus
changed the title
|
After conversation with @Deathreus we'll be leaving the vector changes for later and take the documentation ones for now. |
Also fixup a couple descriptions in the methodmap
|
What happened with the submodules? Revert those changes before merging! |
|
@peace-maker thank you for keeping an eye out, but I’m aware. It’s an issue with rebase picking it’s own submodule commits instead of origin/master’s |
5 participants
Also fixup a couple descriptions in the methodmap