Fix TF2_MakeBleed using incorrect custom damage type#1163
Merged
Headline merged 1 commit intoalliedmodders:masterfrom Feb 9, 2020
Merged
Fix TF2_MakeBleed using incorrect custom damage type#1163Headline merged 1 commit intoalliedmodders:masterfrom
Headline merged 1 commit intoalliedmodders:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #965 accidentally changed
TF2_MakeBleedcustom damage type from 34 (TF_CUSTOM_BLEEDING) to 32 (TF_CUSTOM_SHOTGUN_REVENGE_CRIT).I don't think using damage custom 32 change anything gameplay wise, but does incorrectly report 32 in
player_deathevent, SDKHooksSDKHook_OnTakeDamage, and whatever other places damage custom uses.