Fix GetSteamAccountID validation opt-out#1158
Merged
KyleSanderson merged 1 commit intoalliedmodders:masterfrom Jan 14, 2020
bottiger1:fix-GetSteamAccountID
Merged
Fix GetSteamAccountID validation opt-out#1158KyleSanderson merged 1 commit intoalliedmodders:masterfrom bottiger1:fix-GetSteamAccountID
KyleSanderson merged 1 commit intoalliedmodders:masterfrom
bottiger1:fix-GetSteamAccountID
Conversation
pass validated parameter to GetSteamId
asherkin
changed the title
Member
|
Have you tested that this change does actually fix the issue? |
Contributor
Author
|
There doesn't seem to be any issues with it, but I am not sure how I am supposed to reproduce the Steam servers being down. |
Member
|
If you have a local server, unplug your Ethernet cable/Disable wifi. |
Contributor
Author
|
@asherkin I tested this yesterday during steam maintenance and it appears to work. Will this fix be merged with 1.10? If not, when will 1.11 be released? |
asherkin
pushed a commit
that referenced
this pull request
Feb 25, 2020
Correctly forward the validated parameter within CPlayer::GetSteamAccountID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pass validated parameter to GetSteamId. Fixes #1157.