WriteBaselines gamedata update after latest csgo update#1153
Merged
asherkin merged 3 commits intoalliedmodders:masterfrom Jan 7, 2020
Merged
WriteBaselines gamedata update after latest csgo update#1153asherkin merged 3 commits intoalliedmodders:masterfrom
asherkin merged 3 commits intoalliedmodders:masterfrom
Conversation
Update to master
Member
|
Thanks for the PR. These sigs seem a bit short and are likely to match a different function rather than failing to match in the future, most of what's being matched against here is just the vprof boilerplate common to many functions. A change that early in the function (for both platforms) is often indicative of the params being changed, did you check they were the same? Has this been tested? |
Member
Author
|
Didn't notice any param changes, and also win sig don't seems to be broken, so I can restore it to what it was before, it is linux one that broke, due to vprof functions are moved into a separate function. |
Member
Author
|
Alright, made them bigger, is that okay? |
asherkin
pushed a commit
that referenced
this pull request
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.