Skip to content

WriteBaselines gamedata update after latest csgo update#1153

Merged
asherkin merged 3 commits intoalliedmodders:masterfrom
GAMMACASE:WriteBaselines_gamedata_update
Jan 7, 2020
Merged

WriteBaselines gamedata update after latest csgo update#1153
asherkin merged 3 commits intoalliedmodders:masterfrom
GAMMACASE:WriteBaselines_gamedata_update

Conversation

@GAMMACASE
Copy link
Member

No description provided.

@asherkin
Copy link
Member

asherkin commented Jan 7, 2020

Thanks for the PR. These sigs seem a bit short and are likely to match a different function rather than failing to match in the future, most of what's being matched against here is just the vprof boilerplate common to many functions. A change that early in the function (for both platforms) is often indicative of the params being changed, did you check they were the same? Has this been tested?

@GAMMACASE
Copy link
Member Author

Didn't notice any param changes, and also win sig don't seems to be broken, so I can restore it to what it was before, it is linux one that broke, due to vprof functions are moved into a separate function.

@GAMMACASE
Copy link
Member Author

Alright, made them bigger, is that okay?

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@asherkin asherkin merged commit cfa4998 into alliedmodders:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants