Track Handle Creation Time For Dump Outputs#1110
Merged
KyleSanderson merged 15 commits intomasterfrom Jul 10, 2020
Merged
Conversation
Headline
added
Works For Me
Member
Author
|
Example of sm_dump_handles output |
Member
|
LGTM. It might be a good idea to log the latest (and possibly oldest) time in |
Member
Author
public void OnPluginStart()
{
ArrayList pacc = new ArrayList();
RegConsoleCmd("sm_test", Command_Test);
}
public Action Command_Test(int client, int args)
{
for (int i = 0; i < 32; i++)
{
DataPack pack = new DataPack();
}
}Using the above plugin and manually calling HandleSystem::TryAndFreeSomeHandles() yields us with the following output |
Headline
changed the title
KyleSanderson
requested changes
Nov 6, 2019
Member
KyleSanderson
left a comment
KyleSanderson
left a comment
There was a problem hiding this comment.
I like the idea of it - hopefully trivial fixes to make this a winner.
dvander
reviewed
Feb 7, 2020
core/logic/HandleSys.cpp
Outdated
| } | ||
|
|
||
| #if defined SUBPLATFORM_SECURECRT | ||
| _invalid_parameter_handler handler = _set_invalid_parameter_handler(_ignore_invalid_parameter); |
Member
There was a problem hiding this comment.
This is begging for some RAII but otherwise patch looks fine to me.
Member
There was a problem hiding this comment.
@Headline ack what dvander said. can you make this a class that does nothing on platforms outside of windows? Happy to take afterwards.
Contributor
|
Hope this will be added sooner than not, a very helpful thing. |
KyleSanderson
requested changes
Jul 9, 2020
core/logic/HandleSys.cpp
Outdated
| } | ||
|
|
||
| #if defined SUBPLATFORM_SECURECRT | ||
| _invalid_parameter_handler handler = _set_invalid_parameter_handler(_ignore_invalid_parameter); |
Member
There was a problem hiding this comment.
@Headline ack what dvander said. can you make this a class that does nothing on platforms outside of windows? Happy to take afterwards.
Headline
force-pushed
the
handle-timestamp
branch
from
d9b6ee1 to
558f922
Compare
KyleSanderson
approved these changes
Jul 10, 2020
fengjixuchui
added a commit
to fengjixuchui/sourcemod
that referenced
this pull request
Jul 10, 2020
handlesys: Output allocation timestamp during panic (alliedmodders#1110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1063
We save a timestamp for every Handle creation that way users are able to get more information on when certain handles are being created when using sm_dump_handles.