Fix ArrayStack.Pop documentation#1099
Merged
Headline merged 1 commit intoalliedmodders:masterfrom Nov 13, 2019
Merged
Conversation
FortyTwoFortyTwo
force-pushed
the
stack-doc
branch
from
7e51ed1 to
b46ade3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PopStackCellworks differently toArrayStack.Popwith same (incorrect) return documentation.PopStackCelluses 2nd param to store value of the stack popped, returning false/true if stack if empty or not.ArrayStack.Popreturns value of the stack popped, throws an error if stack is empty.Also fixed
ArrayStack.PopStringwithoaramwhile i'm at it. I'm not so great at english, so please do tell me if there a better wording for return documentation, thanks.