Fix admin map chooser not using display names for menu#1097
Merged
asherkin merged 1 commit intoalliedmodders:masterfrom Oct 7, 2019
Merged
Fix admin map chooser not using display names for menu#1097asherkin merged 1 commit intoalliedmodders:masterfrom
asherkin merged 1 commit intoalliedmodders:masterfrom
Conversation
asherkin
approved these changes
Oct 7, 2019
Contributor
|
i'm think is not good idea.
|
Contributor
Author
|
That's already an issue with using display names in the votemap menu with PR #354. Personally, I'm indifferent on disambiguation (how many server ops have maps that share the same exact display name?). Having a togglable option to use the result of |
Headline
pushed a commit
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the SM Discord:
This copies the display name-related lines from the
LoadMapListfunction inbasevotes/votemap.sptobasecommands/map.sp. It's otherwise left as-is — I'd have no issues changing the styling / hoisting the variable declaration to make it more consistent if desired.