Fix rare crash bug in SDKTools GetGameRulesProxyEnt#1089
Merged
KyleSanderson merged 1 commit intoalliedmodders:masterfrom Nov 6, 2019
Merged
Fix rare crash bug in SDKTools GetGameRulesProxyEnt#1089KyleSanderson merged 1 commit intoalliedmodders:masterfrom
KyleSanderson merged 1 commit intoalliedmodders:masterfrom
Conversation
KyleSanderson
approved these changes
Nov 6, 2019
Member
|
Sorry man - thank you very much for the patch and crash fix. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/game/server/ServerNetworkProperty.cpp#L157
m_pOuter can be NULL and then GetServerClass would crash
so check m_pOuter first with GetEntityHandle:
https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/game/server/ServerNetworkProperty.cpp#L103
Using GameRules_SetProp would sometimes crash for us, after this fix it hasn't crashed for 2 weeks and it doesn't look wrong to check this either.