Check short name for remote extensions#1053
Merged
dvander merged 1 commit intoalliedmodders:masterfrom Nov 12, 2019
Merged
Conversation
Member
|
What are you using the remote extension API for? As per the existing comment here we don't really expect there to be any consumers. This change looks fine - is there any reason to check the path rather than just the short name? |
Contributor
Author
|
I'm exposing some natives from RCBot2 (branch not pushed yet) while keeping it as a MetaMod:Source plugin. I'm sure there's other ways to handle it, but the first useful resource I found while working on it was this wiki entry, so I went with that. I kept the path handling as-is for backwards compatibility since it's already there. |
Member
|
Indeed this code is basically untested as we never really supported it. This change looks harmless though so let's take it. |
dvander
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks the filename passed in via
LoadExternalfor remote extensions for same-file tests.This fixes
FindExtensionByFilenot finding an existing remote extension in the case where the filepath is not equal to the filename (and subsequently loading it twice) and allows plugins to successfully load when specifying that name as a dependency.