Conversation
asherkin
approved these changes
Jun 1, 2019
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
One inline, happy either way though.
| #define SOURCE_BIN_EXT ".so" | ||
| #endif | ||
|
|
||
| #define FORMAT_SOURCE_BIN_NAME(basename) \ |
Member
There was a problem hiding this comment.
Think I'd prefer things without this macro, they're evil.
Member
Author
There was a problem hiding this comment.
I thought about it. I prefer the macro over duplicated logic, and wasn't sure how to otherwise consolidate the concatenation logic at compile-time without it.
Member
Author
There was a problem hiding this comment.
@Headline I still couldn't find a way to do that, other than including a separate header's worth of copy/pasted constexpr abuse to allow for compile-time string concatenation. (Or doing it at runtime).
I'm going to merge as-is, but feel free to improve upon it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #1006, the matchmaking_ds binary is not found since our path to it is incorrect.
This changes our lookup to just use the binary name instead of including the path - similar to how we find tier0 and/or vstdlib to find symbols in those. Only tested on Windows, but that confirms that the binary is loaded by the time our lookup runs, so it should also be fine for dlopen.