Conversation
peace-maker
requested changes
May 27, 2019
Member
Author
|
Since dependency iteration has never historically functioned correctly, it is now deprecated. Extensions have a very specific place alongside SourceMod, and their goal is to extend SourceMod's plugin API and provide an extension to SourceMod functionality. There was never really a need for this feature in the first place and this change allows us to further solidify our expectations for what an extension is meant to be. |
dvander
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran the cppcheck static analyzer against /core/ to check if we were doing any ugliness that I didn't know about. Turns out there's a few situations where we were regressed.
First, and likely the most significant, was
CExtension::FindNextDependency. This method must not have worked correctly for many many years. All operations were mistakenly done on a default-constructed iterator.Secondly,
realloccan fail. By doing assignment directly on the result ofreallocwe miss the opportunity to check if the retval is null or not. If it is null, then our memory allocated previously is still valid and we've just successfully leaked it. For the case involvingInternalFormat, an exception was added for realloc failures.Finally,
1<<31is undefined behavior as1is an int32.Also switched some casts to static_cast because this is c++, after all...