Fix wrong formating to "Vote Delay Minutes" when delay above 60s#1009
Merged
asherkin merged 4 commits intoalliedmodders:masterfrom May 12, 2019
PlayBoy31:master
Merged
Fix wrong formating to "Vote Delay Minutes" when delay above 60s#1009asherkin merged 4 commits intoalliedmodders:masterfrom PlayBoy31:master
asherkin merged 4 commits intoalliedmodders:masterfrom
PlayBoy31:master
Conversation
Member
|
Unless I'm being silly, shouldn't the |
Member
|
We still want it to wrap around 60 as that's our current unit of time. FormatTime is likely the most correct fix here. |
Contributor
Author
|
FormatTime is not appropriate and a time stamp must be used Some solutions:
|
Contributor
Author
Ok corrected as your suggest |
asherkin
approved these changes
May 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1007