TFCond Descriptions#1005
Merged
asherkin merged 3 commits intoalliedmodders:masterfrom Jun 1, 2019
Batfoxkid:tf2-cond-desc
Merged
TFCond Descriptions#1005asherkin merged 3 commits intoalliedmodders:masterfrom Batfoxkid:tf2-cond-desc
asherkin merged 3 commits intoalliedmodders:masterfrom
Batfoxkid:tf2-cond-desc
Conversation
This is mainly for API (https://sm.alliedmods.net/new-api/tf2/TFCond) to show description of the condition.
Member
|
Where were these sourced from? |
Contributor
Author
https://wiki.teamfortress.com/wiki/Cheats#addcond |
Member
|
I think I would prefer this without the numbers - if the numeric values are useful they should be specified as part of the enum or displayed by the doc tool. Thoughts? |
Contributor
Author
|
Probably yeah, I do like some way of showing numeric values so that way for people who don't want to use the full name and instead do |
asherkin
approved these changes
Jun 1, 2019
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
A lot of people seem to like the numbers for this enum, so lets take this with them and look at a large doctool change later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comments about the conditions in tf2.inc. This is mainly for the API to show description of the condition. Just a small thing.