-
-
Notifications
You must be signed in to change notification settings - Fork 464
Closed
Description
I lately edited a certain plugin to conditionally add the "Exit back" button to its custom clientprefs menu depending on whether it was opened through sm_settings or a direct command, but, I thought of also checking GetMenuExitBackButton through the custom items' selections to keep the button visibility decision on menu re-instantiation.
However, it always returned false on the MenuAction_Select cases, and then, leading to the native API code seems to prove it's comparing against the wrong stored flag (MENUFLAG_BUTTON_EXIT):
sourcemod/core/logic/smn_menus.cpp
Line 1017 in 1fbe5e1
| return ((menu->GetMenuOptionFlags() & MENUFLAG_BUTTON_EXITBACK) == MENUFLAG_BUTTON_EXIT) ? 1 : 0; |
Is this a clear mistake or I'm missing something? If I shall create a PR, that'd be straightforward.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels