Skip to content

GetMenuExitBackButton is bugged? #1645

@Adrianilloo

Description

@Adrianilloo

I lately edited a certain plugin to conditionally add the "Exit back" button to its custom clientprefs menu depending on whether it was opened through sm_settings or a direct command, but, I thought of also checking GetMenuExitBackButton through the custom items' selections to keep the button visibility decision on menu re-instantiation.

However, it always returned false on the MenuAction_Select cases, and then, leading to the native API code seems to prove it's comparing against the wrong stored flag (MENUFLAG_BUTTON_EXIT):

return ((menu->GetMenuOptionFlags() & MENUFLAG_BUTTON_EXITBACK) == MENUFLAG_BUTTON_EXIT) ? 1 : 0;

Is this a clear mistake or I'm missing something? If I shall create a PR, that'd be straightforward.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions