You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7a5b4eb
Browse filesBrowse the repository at this point in the historyBrowse files
fix(selectors): keep downgraded target annotations under the payload ceiling (callstack#4354)
* fix(selectors): keep downgraded target annotations under the payload ceiling
Field caps count raw UTF-8 bytes while the 4096-byte ceiling counts escaped JSON, so escape-heavy fields could leave an unverifiable annotation that its own parser rejects. After the downgrade the writer now drops rect, scrollRegion, the remaining ancestry, then label, measuring after each drop. Replay refuses recorded unverifiable evidence before reading these fields, and role plus id always fit.
Fixescallstack#4333
* fix(selectors): check the payload ceiling after the last downgrade drop
The writer now measures again after dropping label and throws if role and id still exceed the ceiling, instead of returning a payload its parser rejects. The role-and-id invariant test derives its bound from the field cap and the largest JSON escape expansion rather than a hand-built payload.
Copy file name to clipboardExpand all lines: docs/adr/0012-interactive-replay.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -66,7 +66,7 @@ An inserted or removed wrapper ancestor changes identity.
66
66
Replay classifies every annotated step before dispatch through six exact verification paths.
67
67
Only a verified result sends the action.
68
68
Anything that the evidence cannot isolate is an `identity-unverifiable` divergence, never a silent pick.
69
-
The recorder must never emit a payload that its parser rejects. The writer downgrades oversized evidence to `verification: "unverifiable"` and drops its rect. Escape-heavy values can still exceed the serialized limit; the implementation does not recheck after dropping the rect.
69
+
The recorder must never emit a payload that its parser rejects. The writer downgrades oversized evidence to `verification: "unverifiable"`, then drops optional fields and measures again after each drop until the serialized payload fits.
70
70
The format is additive. Old readers ignore the comment, and new readers run unannotated actions without the check.
71
71
An annotation binds only to the next physical action line.
0 commit comments