Fix panic error when file is not found#51
Merged
aligator merged 2 commits intoaligator:masterfrom Feb 10, 2022
Merged
Conversation
aligator
requested changes
Feb 9, 2022
Owner
There was a problem hiding this comment.
Thanks you for contributing :-)
Your way works, but I would prefer to check that in the reader/reader.go
Sorry for not describing that more exactly in the issue description...
However, there you can check for file existence in the Read method and then just return the os.ErrNotExist error in case it doesn't.
That should then automatically be catched by the "error while processing file:" catch.
That way we avoid file-loading specific logic inside of the main.go.
Contributor
Author
|
Thanks you for your review, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a condition to check if the file exist and exit if it doesn't.