Added start/end gcode options, as well as toggling heated bed#45
Merged
aligator merged 4 commits intoaligator:masterfrom Oct 23, 2021
Merged
Conversation
aligator
requested changes
Oct 20, 2021
Owner
aligator
left a comment
aligator
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution :-)
I have some change requests and suggestions for you to consider.
Have a nice day :-)
Co-authored-by: Johannes Hörmann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17
I added start and end gcode options, which can be entered on the command line.
Added tests to confirm, as well as manual command line testing.
I also added an option to toggle a heated bed, so that if you don't have a bed to heat, it won't add the bed heating start/end gcode.
GCode in options will override defaults, unless there is no temp commands. If those are missing (m104,m109,m140,m190) the corresponding commands will be added, unless ForceSafeStartStopGCode is set to false.
Start code expects {print_bed_temperature} and {print_temperature} to match cura startcode macros.