Skip to content

Add PHP-focused issue-implementation skill with Composer, static analysis, and security guidance#377

Merged
nicobistolfi merged 2 commits intomainfrom
vigilante/issue-362-add-a-php-focused-vigilante-issue-implementation-skill-with-composer-static-analysis-and-security-guidance
Apr 2, 2026
Merged

Add PHP-focused issue-implementation skill with Composer, static analysis, and security guidance#377
nicobistolfi merged 2 commits intomainfrom
vigilante/issue-362-add-a-php-focused-vigilante-issue-implementation-skill-with-composer-static-analysis-and-security-guidance

Conversation

@nicobistolfi
Copy link
Copy Markdown
Collaborator

Summary

  • Adds TechStackPHP detection via composer.json in repository classification
  • Adds vigilante-issue-implementation-on-php skill with Composer, testing, static analysis, formatting, and security guidance
  • Adds PHP security guidance (password hashing, input validation, serialization, secrets, dependency audit) injected into prompts for PHP repositories
  • Adds mixed-language guidance when PHP repos coexist with Node.js or Go

Changes

  • internal/repo/repo.go: TechStackPHP constant, detectPHPTechStack() function
  • internal/skill/skill.go: VigilanteIssueImplementationOnPHP constant, registration, isPHPTarget() helper, selection logic
  • internal/skill/security.go: phpSecurityGuidance() and 9 helper functions for PHP-specific guidance sections
  • skills/vigilante-issue-implementation-on-php/SKILL.md: Full PHP skill instructions
  • skills/vigilante-issue-implementation-on-php/agents/openai.yaml: Agent interface definition
  • skillassets.go: Updated embed directive to include PHP skill

Test plan

  • 3 new tests in repo_test.go for PHP detection (composer.json present, absent, PHP+Node.js dual detection)
  • 11 new tests in skill_test.go for PHP skill selection, prompt content, non-PHP exclusion, mixed-language guidance, Go-over-PHP priority, monorepo-over-PHP priority
  • Full test suite passes with no regressions (go test ./...)
  • go vet ./... and gofmt clean

Closes #362

@nicobistolfi nicobistolfi force-pushed the vigilante/issue-362-add-a-php-focused-vigilante-issue-implementation-skill-with-composer-static-analysis-and-security-guidance branch 6 times, most recently from 0ef574b to 9069806 Compare April 2, 2026 18:59
@nicobistolfi nicobistolfi force-pushed the vigilante/issue-362-add-a-php-focused-vigilante-issue-implementation-skill-with-composer-static-analysis-and-security-guidance branch from 9069806 to bbdc9cb Compare April 2, 2026 19:08
@nicobistolfi nicobistolfi merged commit b8ffb35 into main Apr 2, 2026
1 check passed
@nicobistolfi nicobistolfi deleted the vigilante/issue-362-add-a-php-focused-vigilante-issue-implementation-skill-with-composer-static-analysis-and-security-guidance branch April 2, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a PHP-focused Vigilante issue-implementation skill with Composer, static analysis, and security guidance

1 participant